Skip to content

Conversation

@prdoyle
Copy link
Contributor

@prdoyle prdoyle commented Mar 11, 2025

Backports the following commits to 8.18:

* Refactor: findRequestingFrame

* INFO instead of WARN for NotEntitledException.

Some of these are expected, so an INFO seems more appropriate.

The stack trace tends to attract attention even when entitlements are not the
cause of a problem, so let's avoid the stack trace, but still include stack
frame info from the frame of interest.

* Use child loggers for Not Entitled logs

* Use warn, and include compoenent name

* Fix ALL_UNNAMED

* Mute entitlement warnings from repositories

* PR feedback

* Common out the Not Entitled prefix.

We're alerting on this, so let's not rely on every caller of notEntitled to remember it.
@prdoyle prdoyle added :Core/Infra/Entitlements Entitlements infrastructure >non-issue auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Core/Infra Meta label for core/infra team test-entitlements labels Mar 11, 2025
@elasticsearchmachine elasticsearchmachine merged commit f547d6c into elastic:8.18 Mar 11, 2025
15 checks passed
@prdoyle prdoyle deleted the backport/8.18/pr-124511 branch March 11, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Core/Infra/Entitlements Entitlements infrastructure >non-issue Team:Core/Infra Meta label for core/infra team v8.18.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants